Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass own props to the div #85

Merged
merged 2 commits into from
Aug 12, 2016
Merged

Don't pass own props to the div #85

merged 2 commits into from
Aug 12, 2016

Conversation

just-paja
Copy link

Since react-15, it is not allowed to pass unknown props to DOM components. This patch adds handling of propTypes to the DateRangePicker object and also removes all recognized props before passing all props to the root div element.

Solves #84, #80

Since react-15, it is not allowed to pass unknown props to DOM components. This patch adds handling of propTypes to the DateRangePicker object and also removes all recognized props before passing all props to the root div element.

Solves #84, #80
@suecom
Copy link

suecom commented Aug 12, 2016

timePicker24hour should be timePicker24Hour

@just-paja
Copy link
Author

@suecom, thank you :)

@skratchdot
Copy link
Owner

Wondering if we can pull this in dynamically (i.e. set PropTypes in the gulp get-options function). I realize we wouldn't know the types automatically, but we could keep a list of known types, and overwrite any new types with any. I like your approach though! Thanks for this!

@skratchdot skratchdot merged commit 5a3960a into skratchdot:master Aug 12, 2016
@Kreozot
Copy link

Kreozot commented Aug 21, 2016

@skratchdot npm publish please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants