remove react-dom dependency #39
Conversation
|
They are deprecating findDOMNode() in this release. It still exists in React for now, but will eventually only be available in react-dom (as far as I know- so if we are going to use it- then it's better to use the react-dom package IMO). Search for The better fix IMO is removing react-dom like you did here, but stop using Changing: To: Can you make that change, then I'll pull this in and test it. If it works, I'll publish a new version today... |
| @@ -5,7 +5,7 @@ | |||
| "main": "./lib/index.js", | |||
| "scripts": { | |||
| "test": "echo \"Error: no test specified\" && exit 1", | |||
| "build": "node ./node_modules/gulp/bin/gulp.js build" | |||
| "build": "gulp build" | |||
There was a problem hiding this comment.
Not sure which version I prefer. Not everyone is going to have gulp installed globally, so I kind of like the node version, since gulp will be installed to node_modules after running npm install.
There was a problem hiding this comment.
this doesn't mean gulp has to be installed globally.
NPM will use the local version if installed (as v2 i believe)
|
cool - didn't know findDOM was being removed. Have updated the PR as requested. Worked fine for me after a rebuild |
| ], | ||
| "engines": { | ||
| "npm": "~2.13.0", | ||
| "node": "~0.12.0" |
There was a problem hiding this comment.
I'm using node 4.0.0 right now, so we should probably change this to > or use a range or something..
There was a problem hiding this comment.
ooh - straight into 4.0. brave! I've not been able to update yet, soon i hope!
If it works with node4 that a > makes sense.
remove react-dom dependency
react-domis not needed