Enable PSRAM #468
Merged
Enable PSRAM #468
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #434 (comment) for why some settings have changed or removed. |
|
I know that we are setting something similar for the multichip design https://github.com/WantClue/esp-miner-multichip/blob/main/sdkconfig.defaults#L12 |
WantClue
added
enhancement
|
please resolve conflict |
|
Done, reverted all other changes in |
WantClue
approved these changes
Dec 21, 2024
eandersson
approved these changes
Dec 21, 2024
eandersson
added a commit
that referenced
this pull request
Dec 22, 2024
This reverts commit e67aa1d.
eandersson
added a commit
that referenced
this pull request
Dec 22, 2024
This reverts commit e67aa1d.
Closed
WantClue
added a commit
to WantClue/ESP-Miner-WantClue
that referenced
this pull request
Dec 22, 2024
This reverts commit e67aa1d.
WantClue
added a commit
that referenced
this pull request
Dec 22, 2024
WantClue
added a commit
that referenced
this pull request
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change in
sdkconfig.defaultsenables PSRAM for the ESP32-S3-WROOM-1 N16R8 variant. This adds 8MB of ram to FreeRTOS.Assumption is that all manufactured BitAxes are using this variant. If there are BitAxes with the 4MB variant, or with no PSRAM, it will probably crash.
The most defensive option is to make sure this code will work on all variants. The other option is to push it out and see what breaks.