Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rejected Shares Percentage Information added #450

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

WhiteyCookie
Copy link
Contributor

resolved conflicts for new UI. Should be fine now

resolved conflicts for new UI
@skot
Copy link
Owner

skot commented Nov 22, 2024

hey @WhiteyCookie sorry it took me so long to review this!

I like having the rejected percentage in the UI a lot. A couple requests;
image

  1. I think we could do with less precision. probably just one decimal place?
  2. Is there some way to cleanly get this all on one line? How about;
  • 8 rejected (6.8%)

@WhiteyCookie
Copy link
Contributor Author

  1. Less precision 1 decimal place could be tricky. For example, in my case I mine on satoshiradio and really having a ridiculous low amount of rejected shares (~0.05%). So I would at least do 2 decimals.
  2. Sure not prob ;)

Less precision (2 decimals) and cleaned format "x rejected (0.00%)"
@WantClue WantClue added good first issue Good for newcomers design Design Enhancements labels Nov 28, 2024
@WantClue WantClue merged commit d69c9db into skot:master Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design Enhancements good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants