Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small change to only-gzip.js to remove warning #449

Merged
merged 1 commit into from
Nov 4, 2024
Merged

small change to only-gzip.js to remove warning #449

merged 1 commit into from
Nov 4, 2024

Conversation

skot
Copy link
Owner

@skot skot commented Nov 4, 2024 •
edited
Loading

we were getting the following warning;

(node:69549) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead
(Use `node --trace-deprecation ...` to show where the warning was created)

So I made the change it suggests, and the warning went away.

Seems to be working fine?

@skot skot requested a review from benjamin-wilson November 4, 2024 01:45
@skot skot self-assigned this Nov 4, 2024
benjamin-wilson
benjamin-wilson approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@benjamin-wilson benjamin-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️ lgtm

@skot skot merged commit d91ed0c into master Nov 4, 2024
2 checks passed
@skot skot deleted the node-warning-fix branch November 4, 2024 01:50
benjamin-wilson pushed a commit that referenced this pull request Nov 16, 2024
@skot
small change to only-gzip.js to remove warning (#449)
2a0470f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamin-wilson benjamin-wilson benjamin-wilson approved these changes

Assignees

@skot skot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skot @benjamin-wilson