Fix websocket logs causing device to crash #277 #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eandersson
changed the title
eandersson
changed the title
eandersson
force-pushed
the
websocket_fix
branch
from
86353dc to
1d4d71d
Compare
eandersson
changed the title
eandersson
changed the title
|
@skot This also fixes the ramp up stuck behavior. I approve this Merge and approve a bug bounty to this as well. |
WantClue
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the issues with the websocket implementation by introducing a thread safe queue to store and read log messages.
There is an additional heap cost with this implementation as we are now queueing log messages, but it should be manageable. For reference I have been running this patch for a few days now and heap is stable, but if there are concerns we could tune
MESSAGE_QUEUE_SIZE.Finally, with this patch I am no longer able to reproduce the bug reported here #277