-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH add HTML repr in notebooks for Card #372
base: main
Are you sure you want to change the base?
Conversation
80b9c88
to
795600e
Compare
results can be seen here: https://skops--372.org.readthedocs.build/en/372/auto_examples/plot_model_card.html#sphx-glr-auto-examples-plot-model-card-py two issues:
|
Hmm, I'm ambivalent about this change. I totally see how it can be useful in notebooks. The way it's rendered in the docs was very confusing to me though. Apart from the two issues that you mentioned, I found it hard to distinguish what is part of the actual docs and what is part of the model card. I wonder if, for the docs, we should keep the default behavior. Maybe rendering the markdown could be done with a different method, not by |
well, sphinx-gallery only understands I agree with not being able to distinguish the notebook from the rendered modelcard though. I wonder if we could do something there to fix that. |
So do we want to go with this first? I.e. only have the nice repr in jupyter notebooks and leave the docs as they were before? If we can come up with a way to fix the identified issues of how docs are rendered, we can add them later. |
This makes for a nice visual in our examples and for people who use notebooks to work with the
Card
object.