Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module with tests and gh workflow #20

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Add module with tests and gh workflow #20

merged 4 commits into from
Feb 29, 2024

Conversation

kornys
Copy link
Member

@kornys kornys commented Feb 29, 2024 •
edited
Loading

  1. Fix dependencies across modules
  2. Add module with tests (it will not be released into mvn packages)
  3. Update to fabric8 6.10 across all modules
  4. Adds workflow for running integration tests against kind

NOTE: Running against mock kube server will be done in scope of different PR

@kornys kornys marked this pull request as draft February 29, 2024 09:31
@kornys kornys marked this pull request as ready for review February 29, 2024 09:36
@kornys kornys linked an issue Feb 29, 2024 that may be closed by this pull request
Create module for run tests against kubernetes #2
Closed
@kornys kornys added this to the 0.1.0 milestone Feb 29, 2024
@kornys
Fix
047703d 
Signed-off-by: David Kornel <[email protected]>
@kornys
Address comments
972009c 
Signed-off-by: David Kornel <[email protected]>
im-konge
im-konge approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kornys kornys merged commit 98971e8 into main Feb 29, 2024
3 checks passed
@kornys kornys deleted the tests branch February 29, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@im-konge im-konge im-konge approved these changes

@Frawless Frawless Frawless approved these changes

Assignees

@kornys kornys

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Create module for run tests against kubernetes
3 participants
@kornys @Frawless @im-konge