Support EU region endpoint #131
Conversation
| @@ -212,7 +220,10 @@ def set_prop(attachment, prop_name, value): | |||
| filename = f"part-{uuid.uuid4().hex}{ext}" | |||
| set_prop(sg_attch, "filename", filename) | |||
| # todo: Read content if stream? | |||
| set_prop(sg_attch, "content", django_attch.get_payload().replace("\n", "")) | |||
| payload = django_attch.get_payload() | |||
| if isinstance(payload, str): | |||
|
@mikemanger have you tested this locally yourself? It's been a few years since I've had access to sendgrid, and the API key that I use for testing (stored as a secret in GitHub) is the only way I have to access the service without paying (I got it for free under some developer program when I first started this repo). |
Yes. I've fixed the secret
For some reason it is now showing as skipping for the original |
|
I think I set it to only run on the main/master to avoid leaking the secret in PRs |
Adds
SENDGRID_HOST_URLto configure the API's root URL. This fixes #129 by allowing people to change the default API endpoint.I thought about using the
set_sendgrid_data_residency()method added in 6.10 (sendgrid/sendgrid-python#1073) however this works with all previous releases and should "just work" if they add more regions in the future.One downside is that to test this you need a separate subuser and API key - I've set this as
TESTING_SENDGRID_EU_API_KEY.I didn't intend to include this but an edge case to the
get_payload()not always returning string is checked before doing a string replace (this is highlighted in more recent versions of mypy).Feedback welcome.