Skip to content

Commit

Permalink
Disable benchmark commenting (unicode-org#3814)
Browse files Browse the repository at this point in the history
  • Loading branch information
robertbastian authored Aug 8, 2023
1 parent 38830d9 commit ff3c7e1
Showing 1 changed file with 10 additions and 11 deletions.
21 changes: 10 additions & 11 deletions .github/workflows/artifacts-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ jobs:
--exclude icu_benchmark_macros
--exclude icu_ffi_coverage
--exclude icu_provider_macros
--exclude tutorials-test
--exclude databake-derive
--exclude yoke-derive
--exclude zerofrom-derive
Expand Down Expand Up @@ -275,10 +274,10 @@ jobs:
# Show alert with commit comment on detecting possible performance regression
alert-threshold: '200%' # If for nothing else, enabling the possibility of alerts with meaningful thresholds requires this job to be done per-component
fail-on-alert: true
comment-on-alert: true
# comment-on-alert: true
github-token: ${{ secrets.GITHUB_TOKEN }}
gh-pages-branch: empty
alert-comment-cc-users: '@sffc,@zbraniecki,@echeran'
# alert-comment-cc-users: '@sffc,@zbraniecki,@echeran'

- name: Upload new benchmark data
if: success() || failure()
Expand Down Expand Up @@ -391,10 +390,10 @@ jobs:
output-file-path: ./benchmarks/memory/${{ matrix.os }}/output.ndjson
alert-threshold: '200%'
fail-on-alert: true
comment-on-alert: true
# comment-on-alert: true
github-token: ${{ secrets.GITHUB_TOKEN }}
gh-pages-branch: empty
alert-comment-cc-users: '@sffc,@zbraniecki,@echeran'
# alert-comment-cc-users: '@sffc,@zbraniecki,@echeran'

- name: Upload new benchmark data
if: success() || failure()
Expand Down Expand Up @@ -493,10 +492,10 @@ jobs:
# Tentative setting, optimized value to be determined
alert-threshold: '200%'
fail-on-alert: true
comment-on-alert: true
# comment-on-alert: true
github-token: ${{ secrets.GITHUB_TOKEN }}
gh-pages-branch: empty
alert-comment-cc-users: '@gnrunge,@sffc,@zbraniecki,@echeran'
# alert-comment-cc-users: '@gnrunge,@sffc,@zbraniecki,@echeran'

- name: Store benchmark result & create dashboard (gz)
if: success() || failure()
Expand All @@ -509,11 +508,11 @@ jobs:
# Tentative setting, optimized value to be determined
alert-threshold: '200%'
fail-on-alert: true
comment-on-alert: true
# comment-on-alert: true
github-token: ${{ secrets.GITHUB_TOKEN }}
gh-pages-branch: empty
skip-fetch-gh-pages: true
alert-comment-cc-users: '@gnrunge,@sffc,@zbraniecki,@echeran'
# alert-comment-cc-users: '@gnrunge,@sffc,@zbraniecki,@echeran'

- name: Upload new benchmark data
if: success() || failure()
Expand Down Expand Up @@ -574,10 +573,10 @@ jobs:
# Tentative setting, optimized value to be determined
alert-threshold: '100%'
fail-on-alert: true
comment-on-alert: true
# comment-on-alert: true
github-token: ${{ secrets.GITHUB_TOKEN }}
gh-pages-branch: empty
alert-comment-cc-users: '@gnrunge,@sffc,@zbraniecki,@echeran'
# alert-comment-cc-users: '@gnrunge,@sffc,@zbraniecki,@echeran'

- name: Upload new benchmark data
if: success() || failure()
Expand Down

0 comments on commit ff3c7e1

Please sign in to comment.