Merge branch 'main' into unicodeset-new-spec

.github/workflows/artifacts-build.yml

@@ -159,6 +159,7 @@ jobs:
       run: |
         cd ffi/diplomat/js/examples/node
         make
+        cd ../wasm-demo
         npm ci
 
     - name: Run Webpack
@@ -544,9 +545,13 @@ jobs:
       run: |
         mkdir -p benchmarks/datasize
 
-    - name: Measure size of selected data package provider/datagen/tests/data/testdata.postcard
+    - name: Generate testdata
       run: |
-        cargo run --package icu_benchmark_binsize  -- provider/datagen/tests/data/testdata.postcard file | tee benchmarks/datasize/output.txt
+        cargo run --bin make-testdata-legacy
+
+    - name: Measure size of selected data package provider/testdata/data/testdata.postcard
+      run: |
+        cargo run --package icu_benchmark_binsize  -- provider/testdata/data/testdata.postcard file | tee benchmarks/datasize/output.txt
 
     - name:  Download previous benchmark data
       run: |

Cargo.toml

@@ -83,7 +83,8 @@ exclude = [
     "ffi/gn",
     # Testdata will still be published in the 1.x stream, but is deprecated
     # and we don't use it anymore. As we don't want to keep the actual data
-    # in the repo it doesn't build without running `cargo make testdata` first.
+    # in the repo it doesn't build without running `cargo make testdata-legacy`
+    # first.
     "provider/testdata",
     # Tutorials are tested in their own cargo workspace against released and
     # local crates

Makefile.toml

@@ -54,7 +54,7 @@ args = ["check", "--all-targets", "--all-features"]
 description = "Check ICU4X build with no features (covered in CI via cargo make check-all-features)"
 category = "ICU4X Development"
 command = "cargo"
-args = ["check", "--all-targets", "--no-default-features"]
+args = ["check", "--no-default-features"]
 
 [tasks.ci-job-msrv-check]
 description = "Run all tests for the CI 'check' job"