Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error handling for invalid gRPC endpoints #757

Merged

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Sep 17, 2024

some hand holding for common error of using http for grpc endpoints

also reformatting a switch case that bothered me

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.99%. Comparing base (4afa6c6) to head (ad58f67).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/connect/main.go 73.33% 4 Missing ⚠️
providers/factories/oracle/marketmap.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #757      +/-   ##
==========================================
+ Coverage   55.56%   56.99%   +1.42%     
==========================================
  Files         208      208              
  Lines       11615    11630      +15     
==========================================
+ Hits         6454     6628     +174     
+ Misses       4558     4398     -160     
- Partials      603      604       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technicallyty technicallyty enabled auto-merge (squash) September 18, 2024 15:21
@technicallyty technicallyty merged commit 04c8ba5 into main Sep 18, 2024
13 checks passed
@technicallyty technicallyty deleted the tyler/stop_people_from_passing_in_dang_http_for_grpc branch September 18, 2024 15:26
aljo242 pushed a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants