Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple bind --expect broken in recent releases (up to 0.13) #622

Closed
ibhagwan opened this issue Nov 27, 2024 · 1 comment · Fixed by #623, #635, #636 or #637
Closed

multiple bind --expect broken in recent releases (up to 0.13) #622

ibhagwan opened this issue Nov 27, 2024 · 1 comment · Fixed by #623, #635, #636 or #637

Comments

@ibhagwan
Copy link

The below works with v10.0.4 but doesn't work with v0.12/v0.13:

sk --expect="ctrl-y,ctrl-g"

Recent releases only work with one key in --expect, both below work:

sk --expect="ctrl-y"                    # Works with only one key
sk --expect="ctrl-y" --expect="ctrl-g"  # Works if split into multiple flags

It might also be worth noting that fzf recently moved away from the --expect approach (had issues combining actions with expect, see junegunn/fzf#3810) and instead added the more versatile print(...) action so it's now possible to emulate (and expand) on --expect with:

For example, using ctrl-q to select-all+accept without losing the bind context in the final results

fzf --bind ctrl-q:select-all+print(ctrl-q)+accept
@LoricAndre
Copy link
Contributor

Same issue with --nth and similar arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants