Avoid unnecessary global variables

[w0rm]

Dragdealer creates 3 global variables (Dragdealer, Cursor, Position). While it would be better to expose only one global that is accessed from the outside of the module.

This can be easily fixed by wrapping module contents in self-executing anonymous function. Another option to consider is to use UMD pattern.

[ovidiuch]

I have this thing written on a note, you read my mind completely :). I thought about the anonymous wrapper but my last impression was that it should simply be Dragdealer, Dragdealer.Cursor, and Dragdealer.Position, change the calls when you're done and that's that.

A cool test would be somehow to check the global entities before loading the dragdealer lib, and then after, expecting only one increment in the number of keys on window. But this is pushing it a bit and you'd probably have to use an iframe for this

Feel free to push for the best option you feel Dragdealer should adopt

[w0rm]

What are your thoughts about adding optional support for AMD? I'm a big fan of requirejs, so I suggest this wrapping:

(function (root, factory) {
  if (typeof define === 'function' && define.amd) {
    // AMD. Register as an anonymous module.
    define(factory);
  } else {
    // Browser globals
    root.Dragdealer = factory();
  }
}(this, function () {
  var Dragdealer = function(){}
  var Cursor = Dragdealer.Cursor = {}
  var Position = Dragdealer.Position = {}
  return Dragdealer;
}));

[ovidiuch]

Sure, I use requirejs a lot. Wasn't aware of this wrapping but looks pretty cool to me.

Don't know if there's a need for the var Cursor = Dragdealer.Cursor = {} thing now, since Dragdealer is all you return.

Awesome stuff!

[w0rm]

var Cursor = Dragdealer.Cursor = {} will allow Dragdealer to use Cursor in local scope so the rest of the code will remain unchanged (no need to replace Cursor with Dragdealer.Cursor)

It will also allow better minification (when local variables get shorter names).

[ovidiuch]

I get that, I was thinking that we drop the Dragdealer.Cursor altogether and leave it like it is now. You think there would be some value in making them public through the Dragdealer namespace? I guess, maybe for debugging, cause I don't think other libs should rely on them through cross-dependencies :)