Wrap module in UMD wrapper #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I get that it is impossible to convert issue into pull request without hub. Will use it next time. And again Travis fails with this error message: |
|
Ran tests locally (don't know what's wrong with Travis/Sauce from forks...) and the passed. Merging this. Yeah, I'll have to get back to my pull request and finish that job, didn't have much time these days, sorry. But it would be awesome to have a proper event listener for a change, the "prevListener" pattern is old as dinosaurs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if we should test that it works with requirejs (I've tested it locally and it works).
But if we need to test this, then we should fix current Cursor implementation, that doesn't allow to use two modules on one page, because it overrides
document.onmousemoveanddocument.ontouchmove. So we have to wait until this commit gets into master, or fix current Cursor to use something similar toDragdealer.prototype.bindEventHandleror add cross-browser listener from this example.Fixes #15.