Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors on boot #93

Merged
merged 3 commits into from
Oct 23, 2017
Merged

Fix errors on boot #93

merged 3 commits into from
Oct 23, 2017

Conversation

gjtorikian
Copy link
Collaborator

Should close #82 and #90.

When the app first launches, it immediately tries to grab a schema from an endpoint URL. But if there's no URL, the fetch function fails with an obscure error.

@zeke
Copy link

zeke commented Oct 23, 2017

Works!

screen shot 2017-10-23 at 4 00 48 pm

@gjtorikian gjtorikian merged commit a46b2b8 into master Oct 23, 2017
@gjtorikian gjtorikian deleted the fix-errors-on-boot branch October 23, 2017 23:07
@Skaronator
Copy link

Thanks for fixing! Could you publish a new version?

@gjtorikian
Copy link
Collaborator Author

Ah, yes, 0.6.3 was made yesterday, but not released on GitHub: https://github.com/skevy/graphiql-app/releases/tag/v0.6.3

And here's the cask update (pending as of this comment): Homebrew/homebrew-cask#39997

@Skaronator
Copy link

Awsome! Thanks for the quick response 👍

@@ -7,6 +7,7 @@
"scripts": {
"dev-server": "webpack-dev-server --config webpack/webpack-dev-server.config.js --progress --colors --port 2992 --inline",
"hot-dev-server": "webpack-dev-server --config webpack/webpack-hot-dev-server.config.js --hot --progress --colors --port 2992 --inline",
"build-dev": "webpack --config webpack/webpack.config.js --progress --profile --colors",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

``

@@ -7,6 +7,7 @@
"scripts": {
"dev-server": "webpack-dev-server --config webpack/webpack-dev-server.config.js --progress --colors --port 2992 --inline",
"hot-dev-server": "webpack-dev-server --config webpack/webpack-hot-dev-server.config.js --hot --progress --colors --port 2992 --inline",
"build-dev": "webpack --config webpack/webpack.config.js --progress --profile --colors",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install with brew, when open give error
4 participants