Add prop-types as a dependency #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 23, 2017 15:43
Bumping this dep creates an error in peer dependencies for codemirror-graphql (from the upstream graphiql repo)
This is marked as a peerDep in upstream graphiql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphiQL has
prop-typesas a peer dependency, which this project doesn't install, resulting in build errors when freshly cloned.I also reverted the version of
graphqlfrom its change in 57242e2, as the updated version no longer meets the peerDep semver range for codemirror-graphql (from the upstream GraphiQL project).Finally, I updated the package-lock.json from a fresh
npm install.