add the close query menu item for non-macOS #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gjtorikian |
shiftkey
changed the title
I'm ready to merge, but as a not-Electron developer, what does this entail? |
|
@gjtorikian at the moment the menu is rendered differently per-platform (this is fine), but the So the current change doesn't even fix that, and it'd be nice to reduce the duplication I think a bit of maintainability in here while I'm cleaning that up. |
|
Ready for review |
shiftkey
changed the title
|
Thank you! |
madzhup
added a commit
to madzhup/graphiql-app
that referenced
this pull request
Oct 16, 2017
* source: Ok npm wants me to commit this Revert "add package lock file (skevy#86)" take shell straight of electron and updated button/links (skevy#87) add package lock file (skevy#86) Update readme (skevy#85) add the close query menu item for non-macOS (skevy#71) Add Origin header for CORS support (skevy#66) Update productName Add release command Update .gitignore Package with Electron Builder, add windows + linux packages Fix bad JSON stringify in get requests (skevy#60) Update to Babel 6 + GraphiQL 0.10.2/GraphQL 0.10.1 # Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70