-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(themes): update Preloading Fonts
section
#2837
docs(themes): update Preloading Fonts
section
#2837
Conversation
- use css property `font-face: swap` instead of preloading the font to not block rendering
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@amjadorfali is attempting to deploy a commit to the Skeleton Labs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @amjadorfali - just a couple small changes needed. Once those are in place I'm happy to merge. Thanks!
@endigo9740 Thanks for the feedback. I resolved your comments |
font-face: swap
instead of preloading the font to not block renderingLinked Issue
Closes #2835
Description
Following the previously recommended guide to Preload fonts makes the font loading event block the rendering of the website and heavily affect LCP. Removing it and using the CSS property
font-face
to handle events on font loading leads to no flickering, and doesn't affect LCP.Changsets
Instructions: Changesets automate our changelog. If you modify files in
/packages
, runpnpm changeset
in the root of the monorepo, follow the prompts, then commit the markdown file. Changes that add features should beminor
while chores and bugfixes should bepatch
. Please prefix the changeset message withfeat:
,bugfix:
orchore:
.Checklist
Please read and apply all contribution requirements.
dev
branch (NEVERmaster
)docs/
,feat/
,chore/
,bugfix/
pnpm ci:check
pnpm format
pnpm test