Feature: migrate skeleton 3 install spinner (#3150)

skeletonlabs · Jan 23, 2025 · f94cd6b · f94cd6b
1 parent 24049a2
commit f94cd6b
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/.changeset/fifty-hounds-confess.md b/.changeset/fifty-hounds-confess.md
@@ -0,0 +1,5 @@
+---
+'@skeletonlabs/skeleton-cli': patch
+---
+
+Feature (migrate/skeleton-3): Installing dependencies shows actual spinner.
diff --git a/packages/skeleton-cli/src/commands/migrate/migrations/skeleton-3/index.ts b/packages/skeleton-cli/src/commands/migrate/migrations/skeleton-3/index.ts
@@ -63,8 +63,6 @@ export default async function (options: MigrateOptions) {
 		return;
 	}
 
-	let theme: string | null = null;
-
 	// Migrate package.json
 	const packageSpinner = spinner();
 	packageSpinner.start(`Migrating ${pkg.name}...`);
@@ -80,6 +78,8 @@ export default async function (options: MigrateOptions) {
 		cli.error('Migration canceled, nothing written to disk');
 	}
 
+	let theme: string | null = null;
+
 	// Migrate tailwind config
 	const tailwindSpinner = spinner();
 	tailwindSpinner.start(`Migrating ${tailwindConfig.name}...`);

diff --git a/packages/skeleton-cli/src/utility/install-dependencies.ts b/packages/skeleton-cli/src/utility/install-dependencies.ts
@@ -1,5 +1,8 @@
 import { detect, resolveCommand } from 'package-manager-detector';
-import { execSync } from 'node:child_process';
+import child_process from 'node:child_process';
+import { promisify } from 'node:util';
+
+const exec = promisify(child_process.exec);
 
 async function installDependencies(cwd = process.cwd()) {
 	const pm = await detect({
@@ -9,9 +12,8 @@ async function installDependencies(cwd = process.cwd()) {
 	if (!resolvedCommand) {
 		throw new Error('Could not resolve package manager command.');
 	}
-	execSync(`${resolvedCommand.command} ${resolvedCommand.args.join(' ')}`, {
-		cwd: cwd,
-		stdio: 'ignore'
+	return exec(`${resolvedCommand.command} ${resolvedCommand.args.join(' ')}`, {
+		cwd: cwd
 	});
 }