Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos #92

Merged
merged 5 commits into from
May 13, 2024
Merged

Fix some typos #92

merged 5 commits into from
May 13, 2024

Conversation

jaakkonakaza
Copy link
Contributor

@jaakkonakaza jaakkonakaza commented May 12, 2024

Description

Noticed the heading below says Changsets instead of Changesets so used a proofreading plugin to find some typos

Changsets

We use Changesets to automatically create our changelog per each release. Any changes or additions to the Library assets in /lib must be documented with a new Changeset. This can be done as follows:

  1. Navigate to the root of the project on your feature branch.
  2. Run pnpm changeset to trigger the Changeset CLI.
  3. Follow the instructions when prompted.
    • Changesets should be either minor or patch. Never major.
    • Prefix your Changeset description using: feature:, chore: or bugfix:.
  4. Changeset .md files are added to the /.changeset directory.
  5. Commit and push the the new changeset file.

Checklist

Please read and apply all contribution requirements.

  • PR targets the dev branch (NEVER master)
  • All website documentation is current with your changes
  • Ensure Prettier formatting is current - run pnpm format
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
floating-ui-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 4:46pm

package.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@Hugos68 Hugos68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!
PS: I see the checklist is left untouched, you can actually check these, this also notifies us you've covered them.

@Hugos68
Copy link
Collaborator

Hugos68 commented May 13, 2024

@endigo9740 Is this good to merge?

@endigo9740
Copy link
Contributor

@Hugos68 @jaakkonakaza I've given my approval, but looks like a minor merge conflict will need to be resolved here.

@Hugos68
Copy link
Collaborator

Hugos68 commented May 13, 2024

I've resolved the conflict, I'll merge once CI passes👍

@Hugos68 Hugos68 merged commit 947918b into skeletonlabs:dev May 13, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants