Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add page titles #88

Merged
merged 3 commits into from
May 12, 2024
Merged

Docs: Add page titles #88

merged 3 commits into from
May 12, 2024

Conversation

Hugos68
Copy link
Collaborator

@Hugos68 Hugos68 commented May 12, 2024

Linked Issue

Partially closes #65

Description

This adds a automatic title generation for every page. This makes it easier to easily spot which page you are on during development as well as make the prod site seem a little more professional.

Changsets

We use Changesets to automatically create our changelog per each release. Any changes or additions to the Library assets in /lib must be documented with a new Changeset. This can be done as follows:

  1. Navigate to the root of the project on your feature branch.
  2. Run pnpm changeset to trigger the Changeset CLI.
  3. Follow the instructions when prompted.
    • Changesets should be either minor or patch. Never major.
    • Prefix your Changeset description using: docs:, feature:, chore: or bugfix:.
  4. Changeset .md files are added to the /.changeset directory.
  5. Commit and push the the new changeset file.

Checklist

Please read and apply all contribution requirements.

  • PR targets the dev branch (NEVER master)
  • All website documentation is current with your changes
  • Ensure Prettier formatting is current - run pnpm format
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm vitest
  • Includes a changeset (if relevant; see above)

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
floating-ui-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 5:45pm

@Hugos68 Hugos68 changed the title Added auto generated titles for now. Docs: Add page titles May 12, 2024
@Hugos68 Hugos68 requested a review from endigo9740 May 12, 2024 14:51
@Hugos68 Hugos68 self-assigned this May 12, 2024
@Hugos68 Hugos68 added the documentation Improvements or additions to documentation label May 12, 2024
Copy link
Contributor

@endigo9740 endigo9740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small item, otherwise looks good!

@Hugos68 Hugos68 merged commit ef8adf6 into dev May 12, 2024
7 checks passed
@Hugos68 Hugos68 deleted the docs/page-titles branch May 12, 2024 19:46
@jaakkonakaza jaakkonakaza mentioned this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add titles to all pages in the docs
2 participants