Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Типы в defaultProps - 2 #2915

Merged
merged 27 commits into from
Jul 27, 2022
Merged

Типы в defaultProps - 2 #2915

merged 27 commits into from
Jul 27, 2022

Conversation

HelenaIsh
Copy link
Contributor

@HelenaIsh HelenaIsh commented Jun 17, 2022 •
edited by dzekh
Loading

fixes #2553
fixes IF-284

Была неудачная попытка исправить default props в #2760

Было решено сделать все пропы, которые есть в defaultProps опциональными, прописав для defaultProps корректный тип

@HelenaIsh HelenaIsh force-pushed the default-props-2 branch 2 times, most recently from 40b8d74 to 8c1785f Compare June 17, 2022 08:09
@HelenaIsh HelenaIsh marked this pull request as ready for review June 20, 2022 06:10
@HelenaIsh HelenaIsh requested a review from JackUait June 20, 2022 11:29
JackUait
JackUait suggested changes Jun 26, 2022
View reviewed changes
packages/react-ui-validations/src/ValidationContainer.tsx Outdated Show resolved Hide resolved
packages/react-ui/components/Radio/Radio.tsx Outdated Show resolved Hide resolved
packages/react-ui/internal/PopupMenu/PopupMenu.tsx Outdated Show resolved Hide resolved
@zhzz zhzz self-requested a review June 28, 2022 12:05
JackUait
JackUait previously approved these changes Jun 29, 2022
View reviewed changes
@HelenaIsh HelenaIsh requested a review from JackUait July 4, 2022 06:13
@HelenaIsh HelenaIsh requested a review from JackUait July 11, 2022 12:10
@JackUait
Copy link
Contributor

Появился конфликт с мастером

@HelenaIsh HelenaIsh marked this pull request as draft July 14, 2022 10:53
@HelenaIsh HelenaIsh marked this pull request as ready for review July 18, 2022 06:29
@HelenaIsh HelenaIsh requested a review from JackUait July 18, 2022 10:13
@dzekh
Copy link

dzekh commented Jul 21, 2022

А этот ПР закроет #2553 ?

@HelenaIsh
Copy link
Contributor Author

А этот ПР закроет #2553 ?

да

JackUait
JackUait previously approved these changes Jul 24, 2022
View reviewed changes
@HelenaIsh HelenaIsh requested a review from zhzz July 25, 2022 05:46
@HelenaIsh HelenaIsh requested a review from zhzz July 26, 2022 06:23
@HelenaIsh HelenaIsh requested a review from JackUait July 27, 2022 11:20
@zhzz zhzz merged commit 72d02d5 into master Jul 27, 2022
@zhzz zhzz deleted the default-props-2 branch July 27, 2022 13:15
@lossir lossir mentioned this pull request Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackUait JackUait JackUait approved these changes

@zhzz zhzz zhzz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@HelenaIsh @JackUait @dzekh @zhzz