-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spinner] Избавиться от анимации с png #2182
Labels
Comments
zhzz
added a commit
that referenced
this issue
Nov 5, 2020
zhzz
added a commit
that referenced
this issue
Nov 6, 2020
zhzz
added a commit
that referenced
this issue
Nov 6, 2020
zhzz
added a commit
that referenced
this issue
Nov 9, 2020
zhzz
added a commit
that referenced
this issue
Nov 9, 2020
zhzz
added a commit
that referenced
this issue
Nov 25, 2020
StathamJason
pushed a commit
that referenced
this issue
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spinner и SpinnerOld представляют из себя анимированные SVG. И там есть fallback-и для IE, потому что он не поддерживает css-анимацию нужных свойств svg. Сделаны они с помощью движущегося png-спрайта.
Это приводит к необходимости загружать эти спрайты и, следовательно, к тем же проблемам, что описаны в #2181.
retail-ui/packages/react-ui/components/Spinner/SpinnerFallback.tsx
Lines 6 to 9 in 94034a3
Но, т.к. сами svg-картинки в IE работают нормально, можно переделать fallback на анимацию их нужных свойств js-ом, избавившись от этих картинок.
The text was updated successfully, but these errors were encountered: