3.x cleanup #22
Merged
3.x cleanup #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xificurk
commented
Apr 5, 2018
xificurk
commented
- Drobná dočištění související s odstraněním podpory pro PHP <5.6 a Nette <2.4.
- typehinty
|
Nestálo by za to zbavit se duplicitních phpdoců v místech, kde je typehint? |
JindrichPilar
approved these changes
Apr 9, 2018
There was a problem hiding this comment.
Zda se ok.
Souhlasim s @fmasa, duplicitni phpdocs nejsou potreba. Ale nechal bych to u poli @return array => @return string[]
JindrichPilar
approved these changes
Apr 10, 2018
fmasa
approved these changes
Apr 10, 2018
|
Jen je potřeba brát v potaz, že přidávání typehintů je minor BC break. Protože ty třídy, kde se tak děje, nejsou final nebo aspoň internal, takže můžou v projektech tyhle třídy dědit a přetěžovat metody, což jim nebude fungovat. |
|
@fmasa tohle cílí 3.x větev, která zatím nemá release, takže BC breaky nevadí. |
|
🤦♂️ Jsem myslel, že jsem na #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.