Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import paths to use gonum.org/v1/gonum #237

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jasonzhuyx
Copy link

@jasonzhuyx jasonzhuyx commented Nov 13, 2019

Since December, 2018, both "gonum/blas" and "gonum/matrix" have been deprecated and migrated to "gonum/gonum".

As "go.mod" (at https://github.com/gonum/gonum) declares

module gonum.org/v1/gonum

this PR includes the changes to use "gonum.org/v1/gonum" as import paths in

  • knn/knn.go
  • linear_models/linear_regression.go
  • metrics/pairwise/chebyshev.go
  • metrics/pairwise/cranberra.go
  • metrics/pairwise/manhattan.go

@jasonzhuyx jasonzhuyx force-pushed the fix-import-path branch 2 times, most recently from 074f523 to 97f6212 Compare November 13, 2019 17:40
@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #237 into master will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   70.78%   70.78%           
=======================================
  Files          68       68           
  Lines        5945     5945           
=======================================
  Hits         4208     4208           
  Misses       1392     1392           
  Partials      345      345
Impacted Files Coverage Δ
linear_models/linear_regression.go 93.84% <ø> (ø) ⬆️
knn/knn.go 76.09% <0%> (ø) ⬆️
metrics/pairwise/manhattan.go 100% <100%> (ø) ⬆️
metrics/pairwise/cranberra.go 100% <100%> (ø) ⬆️
metrics/pairwise/chebyshev.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fcc2b4...d252e11. Read the comment docs.

knn/knn.go Outdated Show resolved Hide resolved
metrics/pairwise/chebyshev.go Outdated Show resolved Hide resolved
metrics/pairwise/cranberra.go Outdated Show resolved Hide resolved
metrics/pairwise/manhattan.go Outdated Show resolved Hide resolved
@mattn mattn mentioned this pull request Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants