fix: issues found by Psalm

sjinks · Jan 21, 2024 · 6d8fa8d · 6d8fa8d
1 parent 63fea7c
commit 6d8fa8d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/inc/class-inputfactory.php b/inc/class-inputfactory.php
@@ -126,6 +126,7 @@ private static function get_attributes( array $params ): string {
 	 * @psalm-param HelpArgs&mixed[] $args
 	 */
 	private static function render_help( array $args ): void {
+		/** @psalm-suppress RiskyTruthyFalsyComparison */
 		if ( ! empty( $args['help'] ) ) {
 			printf(
 				'<p class="help">%s</p>',

diff --git a/inc/class-utils.php b/inc/class-utils.php
@@ -33,7 +33,7 @@ public static function create_webauthn_server(): ServerInterface {
 		$builder = new ServerBuilder();
 		$party   = new RelyingParty( get_bloginfo( 'name' ), self::get_u2f_app_id() );
 
-		if ( COOKIE_DOMAIN ) {
+		if ( (string) COOKIE_DOMAIN ) {
 			$id = ltrim( (string) COOKIE_DOMAIN, '.' );
 			$party->setId( $id );
 		}

diff --git a/inc/class-webauthn-user.php b/inc/class-webauthn-user.php
@@ -76,6 +76,7 @@ public function get_user_handle_if_exists(): ?UserHandle {
 			wp_cache_set( $key, $handle, self::CACHE_GROUP_NAME, 3600 );
 		}
 
+		/** @psalm-suppress RiskyTruthyFalsyComparison */
 		return $handle ? UserHandle::fromString( $handle ) : null;
 	}
 
@@ -103,6 +104,7 @@ public static function get_user_by_handle( UserHandle $handle ): ?WP_User {
 			wp_cache_set( $key, (int) $user_id, self::CACHE_GROUP_NAME, 3600 );
 		}
 
+		/** @psalm-suppress RiskyTruthyFalsyComparison */
 		return $user_id ? new WP_User( (int) $user_id ) : null;
 	}
 }