Skip to content

Commit

Permalink
Merge pull request #297 from sjinks/GH-295
Browse files Browse the repository at this point in the history
fix: Patch client extension verification
  • Loading branch information
sjinks authored Oct 26, 2022
2 parents 6f689db + b7bb282 commit 0b57a40
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 2 deletions.
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@
},
"patches": {
"madwizard/webauthn": {
"Fix interoperability with imposter": "patches/webauthn.patch"
"Fix interoperability with imposter": "patches/webauthn.patch",
"Fix client extension verification (GH-295)": "patches/client-extensions.patch"
}
}
},
Expand Down
2 changes: 1 addition & 1 deletion composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions patches/client-extensions.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
--- src/Server/AbstractVerifier.orig.php 2022-10-26 07:04:02.916968205 +0300
+++ src/Server/AbstractVerifier.php 2022-10-26 07:10:31.212763949 +0300
@@ -91,7 +91,7 @@
foreach ($results as $id => $result) {
$input = $inputs[$id] ?? null;
if ($input === null) {
- throw new VerificationException(sprintf('Extension "%s" is present in clientExtensionResults but was not used in the input.', $id));
+ continue;
}
$extension = $this->extensionRegistry->getExtension($id);

0 comments on commit 0b57a40

Please sign in to comment.