Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove only-allow pre-install due to issue installing with npm #153

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

sjdemartini
Copy link
Owner

Fixes #152 and #151. This seems to be due to a bug in only-allow that specifically affects npm, where the only-allow goes into effect even when installing the package as a dependency: pnpm/only-allow#13

Fixes #152. This seems
to be due to a bug in only-allow that specifically affects `npm`, where
the `only-allow` goes into effect even when installing the package as a
dependency: pnpm/only-allow#13
@sjdemartini sjdemartini enabled auto-merge (rebase) September 14, 2023 14:19
@sjdemartini sjdemartini merged commit 70791f7 into main Sep 14, 2023
1 check passed
@sjdemartini sjdemartini deleted the remove-only-allow branch September 14, 2023 14:21
@lcarlso2
Copy link

Thanks man! This rte is by far the slickest ive come across, but this was a show stopper. Thank you!!

@sjdemartini
Copy link
Owner Author

Thanks @lcarlso2, I appreciate it, and thanks for reporting the bug! This fix is in v1.8.2, just published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error [email protected] preinstall: npx only-allow pnpm
2 participants