Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve appearance for table and database nested in container block #13052

Closed
Vanessa219 opened this issue Nov 6, 2024 · 8 comments
Closed
Assignees
Milestone

Comments

@Vanessa219
Copy link
Member

Vanessa219 commented Nov 6, 2024

解决嵌套和有颜色的块下数据库和表格颜色问题

#12713
#12951

QQ_1730864850344

@Vanessa219 Vanessa219 self-assigned this Nov 6, 2024
Vanessa219 added a commit that referenced this issue Nov 6, 2024
Vanessa219 added a commit that referenced this issue Nov 6, 2024
@Vanessa219 Vanessa219 added this to the 3.1.12 milestone Nov 6, 2024
@TCOTC
Copy link
Contributor

TCOTC commented Nov 8, 2024

嵌入块那个左侧虚线框看起来怪怪的,

我建议把

.protyle-wysiwyg [data-node-id].render-node[data-type=NodeBlockQueryEmbed] {
    border-left: 1px dashed var(--b3-theme-surface-lighter);
}

换成

.protyle-wysiwyg [data-node-id].render-node[data-type=NodeBlockQueryEmbed] {
    border: 1px dashed var(--b3-theme-surface-lighter);
}

TCOTC added a commit to TCOTC/siyuan that referenced this issue Nov 8, 2024
@88250 88250 changed the title 解决嵌套和有颜色的块下数据库和表格颜色问题 Improve appearance for table and database nested in container block Nov 9, 2024
Vanessa219 added a commit that referenced this issue Nov 13, 2024
Vanessa219 pushed a commit that referenced this issue Nov 13, 2024
@TCOTC
Copy link
Contributor

TCOTC commented Nov 19, 2024

@Vanessa219 没了背景色之后不是很好分辨,外框感觉太细了,换成 2px 吧?

@Vanessa219
Copy link
Member Author

2px 太粗了,不够精细。1px 看上去已经很明显了。

image

@TCOTC
Copy link
Contributor

TCOTC commented Nov 19, 2024

总感觉太细了,那 1.25px 怎么样?

image

@Vanessa219
Copy link
Member Author

1.25 我电脑上看不出区别来

@TCOTC
Copy link
Contributor

TCOTC commented Nov 19, 2024

1.5px 呢?

@Vanessa219
Copy link
Member Author

要不改一下边框的颜色?

@TCOTC
Copy link
Contributor

TCOTC commented Nov 19, 2024

颜色再深一点的话好像也行

Vanessa219 added a commit that referenced this issue Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants