fix rendering for script/comment/CDATA inside content tags in FastPageParser.java #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix script/CDATA/comment rendering inside of content tag. reference: https://jira.atlassian.com/browse/CONF-16098 https://jira.atlassian.com/browse/JRA-16503 Details: we fixed the output to _buffer while in content tag (tagged = true) behavior before fix: <content tag="..."> <!--comment--> <script src="..."> <![CDATA[MyData]]> <!--<--><script src="..."> ;-) </content> rendered to (leading '<' is missing, comment is no comment anymore, CDATA not quoted) <content tag="..."> comment script src="..."> MyData <script src="..."> </content> after fix rendered to: <content tag="..."> <!--comment--> <script src="..."> <![CDATA[MyData]]> <!--<--><script src="..."> </content> sorry, no tests written.
hazendaz
added a commit
to hazendaz/sitemesh2
that referenced
this pull request
May 13, 2023
…eParser.java resolves sitemesh#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix script/CDATA/comment rendering inside of content tag.
reference:
https://jira.atlassian.com/browse/CONF-16098
https://jira.atlassian.com/browse/JRA-16503
Details:
we fixed the output to _buffer while in content tag (tagged = true)
behavior before fix:
<script src="..."> <script src="..."> ;-) rendered to (leading '<' is missing, comment is no comment anymore, CDATA not quoted) comment script src="..."> MyData <script src="..."> after fix rendered to: <script src="..."> <script src="..."> sorry, no tests written.