Add option to disable request logs

[dmarcoux]

Closes #785

[dmarcoux]

I tried to test this locally by adding env = LD_DISABLE_LOGGING=true to uwsgi.ini and spinning up the server with uwsgi --http :8000 --module siteroot.wsgi. The logs were still being shown. I am not super familiar with uWSGI, maybe someone could guide me here?

[sissbruecker]

It's an environment variable, so you either set it using export LD_DISABLE_LOGGING=1 when testing locally, or adding -e LD_DISABLE_LOGGING=1 when starting the Docker container.

The change seems to work. Naming isn't great, as it doesn't really disable logging:

• It only disables request logs
• It will still log failed requests
• It will still log stuff from linkding itself

Apart from that the option should be documented in the options docs.

[dmarcoux]

My first attempt to test this was with LD_DISABLE_LOGGING=1 python3 manage.py runserver, but I could still see the request logs (for example from the /health endpoint). This is from linkding, so it stays, right?

Anyway, it's true that the naming isn't great. Maybe LD_QUIETER_LOGGING? Naming things is hard 😄

[sissbruecker]

My first attempt to test this was with LD_DISABLE_LOGGING=1 python3 manage.py runserver

That command uses the Django dev server, and not uwsgi. I guess LD_DISABLE_LOGGING=1 uwsgi --http :8000 --module siteroot.wsgi should do it then.

Regarding naming, LD_DISABLE_REQUEST_LOGS would be more appropriate IMO, if not 100% correct. But could be fine if the docs mention that failed requests are still logged.

[aerz]

Hi, the option values don't use the capitalized format. Shouldn't they be True or False like the other options?

Thanks @dmarcoux for this feature!