Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGES: Accessor names of Sisimai::Fact, Key names of JSON will be changed #563

Open
azumakuniyuki opened this issue Dec 20, 2024 · 0 comments
Open

BREAKING CHANGES: Accessor names of Sisimai::Fact, Key names of JSON will be changed #563

azumakuniyuki opened this issue Dec 20, 2024 · 0 comments
Assignees
@azumakuniyuki
Labels
enhancement

Comments

@azumakuniyuki
Copy link
Member

  • Change sis.Fact{} member name go-sisimai#8
  • smtpagent => decodedby
    • The value of this member is a sisimai/lhost module name which decoded a bounce message.
    • Word Agent is ambiguous
    • old name smtpagent could be accessed until v5.5.0
  • smtpcommand => command
    • SMTP is the obvious choice of command when handling bounce emails.
    • old name smtpcommand could be accessed until v5.5.0
@azumakuniyuki azumakuniyuki self-assigned this Dec 20, 2024
azumakuniyuki added a commit that referenced this issue Dec 20, 2024
@azumakuniyuki
Accessor "smtpagent" has been renamed to "decodedby" for the compatib…
bc0b5d9 
…ility with the Go language version of sisimai #563
azumakuniyuki added a commit that referenced this issue Dec 20, 2024
@azumakuniyuki
Implement Sisimai::Fact->smtpagent() for the backward compatibility #563
887ffcc
@azumakuniyuki azumakuniyuki mentioned this issue Dec 20, 2024
Open
azumakuniyuki added a commit that referenced this issue Dec 20, 2024
@azumakuniyuki
Accessor "smtpcommand" has been renamed to "command" #563
cf459ba
azumakuniyuki added a commit that referenced this issue Dec 20, 2024
@azumakuniyuki
Suppress warning messages at "make test" until v5.5.0 #563
b5d3f62
@azumakuniyuki azumakuniyuki mentioned this issue Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azumakuniyuki azumakuniyuki

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@azumakuniyuki