enh: use readonly collection instead of array (#15)

Signed-off-by: Sang Au <[email protected]>
sisa-solutions · Oct 21, 2024 · f2298a9 · f2298a9
1 parent a202845
commit f2298a9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/src/CertGen/CommandOptions/CreateEcdsaCommandOptions.cs b/src/CertGen/CommandOptions/CreateEcdsaCommandOptions.cs
@@ -13,7 +13,7 @@ public sealed class CreateEcdsaCommandOptionsBinder(
     Option<string> certName,
     Option<Algorithm> algorithm,
     Option<NamedCurve> namedCurve,
-    Option<string[]> dnsNames,
+    Option<IReadOnlyCollection<string>> dnsNames,
     Option<string?> pfxPassword,
     Option<string?> organizationName,
     Option<string?> organizationUnitName,

diff --git a/src/CertGen/CommandOptions/CreateRsaCommandOptions.cs b/src/CertGen/CommandOptions/CreateRsaCommandOptions.cs
@@ -13,7 +13,7 @@ public sealed class CreateRsaCommandOptionsBinder(
     Option<string> certName,
     Option<Algorithm> algorithm,
     Option<int> keySize,
-    Option<string[]> dnsNames,
+    Option<IReadOnlyCollection<string>> dnsNames,
     Option<string?> pfxPassword,
     Option<string?> organizationName,
     Option<string?> organizationUnitName,
@@ -28,8 +28,7 @@ public sealed class CreateRsaCommandOptionsBinder(
     commonName
 )
 {
-    protected override CreateRsaCommandOptions GetBoundValue([NotNull
-    ] BindingContext bindingContext) =>
+    protected override CreateRsaCommandOptions GetBoundValue([NotNull] BindingContext bindingContext) =>
         base.GetBoundValue(bindingContext) with
         {
             KeySize = bindingContext.ParseResult.GetValueForOption(keySize)

diff --git a/src/CertGen/CommandOptions/GlobalOptions.cs b/src/CertGen/CommandOptions/GlobalOptions.cs
@@ -24,7 +24,7 @@ public record GlobalOptions
 public abstract class GlobalOptionsBinder<TOptions>(
     Option<string> certName,
     Option<Algorithm> algorithm,
-    Option<string[]> dnsNames,
+    Option<IReadOnlyCollection<string>> dnsNames,
     Option<string?> pfxPassword,
     Option<string?> organizationName,
     Option<string?> organizationUnitName,

diff --git a/src/CertGen/Handlers.cs b/src/CertGen/Handlers.cs
@@ -35,7 +35,7 @@ public static Command Initialize()
 
         algorithmOption.AddAlias("-a");
 
-        var dnsNamesOption = new Option<string[]>(
+        var dnsNamesOption = new Option<IReadOnlyCollection<string>>(
             name: "--dns-names",
             description: "DNS names for the certificate",
             getDefaultValue: () => ["localhost"]