CI: use GitHub Actions #1239
Merged
CI: use GitHub Actions #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully fix cross-compile on openbsd/mips64 on Go 1.16
Building for GOOS=openbsd GOARCH=mips64
# golang.org/x/sys/unix
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/fcntl.go:26:42: undefined: Flock_t
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/ioctl.go:26:47: undefined: Winsize
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/ioctl.go:37:47: undefined: Termios
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/ioctl.go:55:42: undefined: Winsize
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/ioctl.go:61:42: undefined: Termios
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/syscall_openbsd.go:34:6: missing function body
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/syscall_unix_gc.go:12:6: missing function body
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/syscall_unix_gc.go:13:6: missing function body
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/syscall_unix_gc.go:14:6: missing function body
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/syscall_unix_gc.go:15:6: missing function body
Error: ../../../go/pkg/mod/golang.org/x/[email protected]/unix/ioctl.go:61:42: too many errors
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
move_to_gha
branch
5 times, most recently
from
d177300 to
ec9df82
Compare
Use GitHub actions to run golang-ci-lint, cross, and test. The "Test()" target in Mage was a plain "go test -v ./...", and should be portable to other CI systems if needed; running it through the mage file effectively resulted in "compile a go binary to run go". The "Lint()" target in Mage relied on Travis CI setting up Golang-CI lint before it was executed, which required bash. Moving it to GitHub actions also allowed it to be run on Windows. Golang CI can still be run locally either through the mage file (which is kept for now), or running `golangci-lint run ./...` after installing golangci-lint. The "CrossBuild() Mage target is still used to perform cross-compile, as it contains code to generate the GOOS/GOARCH matrix, which makes it easier to run locally. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
move_to_gha
branch
from
ec9df82 to
cbd14ed
Compare
|
I opened thaJeztah#1 to test this (GH Actions don't run on a repository until merged). |
|
@thaJeztah let's merge that and see how it fares versus travis |
|
Thanks! Feel free to "ping" me in case there's issues 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GitHub actions to run golang-ci-lint, cross, and test.
The "Test()" target in Mage was a plain "go test -v ./...", and should be
portable to other CI systems if needed; running it through the mage file
effectively resulted in "compile a go binary to run go".
The "Lint()" target in Mage relied on Travis CI setting up Golang-CI lint
before it was executed, which required bash. Moving it to GitHub actions
also allowed it to be run on Windows. Golang CI can still be run locally
either through the mage file (which is kept for now), or running
golangci-lint run ./...after installing golangci-lint.The "CrossBuild() Mage target is still used to perform cross-compile, as it
contains code to generate the GOOS/GOARCH matrix, which makes it easier
to run locally.