Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text formatter should have a field that enables quoting all fields #1026

Closed
wants to merge 1 commit into from
Closed

text formatter should have a field that enables quoting all fields #1026

wants to merge 1 commit into from

Conversation

spilliams
Copy link

addresses #1005

freeformz
freeformz approved these changes Sep 20, 2019
View reviewed changes
Copy link
Collaborator

@freeformz freeformz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't like this option, but I don't think that should be a reason to reject it either.

@freeformz
Copy link
Collaborator

@spilliams I'm sorry, I merged #1042 because I overlooked this one. :-( If you want to rebase to capture the one missing test group, or adjust language, etc I'd be happy to merge this. Thanks!

@spilliams
Copy link
Author

No worries. Thanks for the update!

@spilliams spilliams closed this Oct 23, 2019
@spilliams spilliams deleted the QuoteAllFields branch October 23, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeformz freeformz freeformz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spilliams @freeformz