Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 45852 #1

Closed
wants to merge 1 commit into from
Closed

Fix 45852 #1

wants to merge 1 commit into from

Conversation

parvit
Copy link

@parvit parvit commented Feb 26, 2023

This, together with the cache fix in PR #46432 solves the issues indicated in the ticket, specifically the explanations are the following to the best of my abilities.

  • Issue 1:

    • Pages caching issue makes the index.tsx files in hotel-host and hotel-guest directories collide and so the index under guest folder is not included in the app => PR #46432 addresses this
  • Issue 2:

    • Fix 45852 #1 also applies here
    • Configuration entry "baseFolder" in the tsconfig.ts files with "." value seems to not be resolved correctly by webpack and the wrong components is resolved as a consequence
    • Default exported App function methods need to be renamed to diffent names so as not to collide, this seems an issue with loading optimization made by webpack but it would require deeper investigation to understand fully

Both the fixes only work fully when next is updated to 13.2.2-canary-0, 13.1.7 still exhibits issue #2, but this could be an effect of my local changes not really sure.

Let me know if any additional steps are required for resolution.

Regards,

@parvit
Copy link
Author

parvit commented Mar 4, 2023

Not necessary anymore.

@parvit parvit closed this Mar 4, 2023
@parvit parvit deleted the fix-45852 branch March 4, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant