Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect clumpy volume division in mc_estimator_normalize #161

Closed
jhmatthews opened this issue Jul 30, 2015 · 0 comments
Closed

Incorrect clumpy volume division in mc_estimator_normalize #161

jhmatthews opened this issue Jul 30, 2015 · 0 comments
Assignees
Labels
bug Bugs in the code urgent

Comments

@jhmatthews
Copy link
Collaborator

When implementing clumping in the code I appear to have made a mistake in the macro-atom estimator normalisation, where quantities such as the gamma and alpha estimators were being divided by the filled volume instead of the real volume.

This isn't right, because a gamma estimator (PI rate) should be identical in a clumped model and non-clumped (with other physical properties fixed), and the alpha_estimator is increased by the enhanced density as it scales as rho**2. This error basically means that Hydrogen heating mechanisms in my QSO models were much higher than they should have been.

This is the only thing which wouldn't have shown up in my tests of microclumping, which I guess means I didn't do my tests well enough...

The good news is that fixing this doesn't change much the output spectra of my QSO models- the temperature structure is a little different in that the wind is cooler near the disk, but tweaking some parameters basically means I can reproduce the spectra that I roughly want. It will not affect any past models as they didn't use clumping. Issue raised here for documentation purposes.

@jhmatthews jhmatthews added bug Bugs in the code urgent labels Jul 30, 2015
@jhmatthews jhmatthews self-assigned this Jul 30, 2015
@jhmatthews jhmatthews added this to the Next AGN paper milestone Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in the code urgent
Projects
None yet
Development

No branches or pull requests

1 participant