You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When implementing clumping in the code I appear to have made a mistake in the macro-atom estimator normalisation, where quantities such as the gamma and alpha estimators were being divided by the filled volume instead of the real volume.
This isn't right, because a gamma estimator (PI rate) should be identical in a clumped model and non-clumped (with other physical properties fixed), and the alpha_estimator is increased by the enhanced density as it scales as rho**2. This error basically means that Hydrogen heating mechanisms in my QSO models were much higher than they should have been.
This is the only thing which wouldn't have shown up in my tests of microclumping, which I guess means I didn't do my tests well enough...
The good news is that fixing this doesn't change much the output spectra of my QSO models- the temperature structure is a little different in that the wind is cooler near the disk, but tweaking some parameters basically means I can reproduce the spectra that I roughly want. It will not affect any past models as they didn't use clumping. Issue raised here for documentation purposes.
The text was updated successfully, but these errors were encountered:
When implementing clumping in the code I appear to have made a mistake in the macro-atom estimator normalisation, where quantities such as the gamma and alpha estimators were being divided by the filled volume instead of the real volume.
This isn't right, because a gamma estimator (PI rate) should be identical in a clumped model and non-clumped (with other physical properties fixed), and the alpha_estimator is increased by the enhanced density as it scales as rho**2. This error basically means that Hydrogen heating mechanisms in my QSO models were much higher than they should have been.
This is the only thing which wouldn't have shown up in my tests of microclumping, which I guess means I didn't do my tests well enough...
The good news is that fixing this doesn't change much the output spectra of my QSO models- the temperature structure is a little different in that the wind is cooler near the disk, but tweaking some parameters basically means I can reproduce the spectra that I roughly want. It will not affect any past models as they didn't use clumping. Issue raised here for documentation purposes.
The text was updated successfully, but these errors were encountered: