Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segfault from reverb code #152

Closed
jhmatthews opened this issue Jun 15, 2015 · 1 comment
Closed

segfault from reverb code #152

jhmatthews opened this issue Jun 15, 2015 · 1 comment
Labels
bug Bugs in the code high

Comments

@jhmatthews
Copy link
Collaborator

Hey @smangham - I'm getting segfault from delay_dump_single() when I run a model with geo.reverb set to zero. I think it's because of these lines in extract.c

    if (pp->nrscat > 0)     // SWM - Records total distance travelled by extract photon
        {
            stuff_v(pstart.x, pp->x);   // Restore photon to initial position (necessary for reweighting)
            pp->path = pstart.path;
                delay_dump_single(pp, 1);       // Dump photon now weight has been modified
        }

so we call delay_dump_single, even though we haven't allocated the space for the delay dump structures- a simple if (geo.reverb>0) here should sort this. Agreed?

Flagged in case it affects @Higginbottom 's runs too

@jhmatthews jhmatthews added bug Bugs in the code high labels Jun 15, 2015
@smangham
Copy link
Collaborator

Yes, definitely- sorry, I thought I had a check in there for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in the code high
Projects
None yet
Development

No branches or pull requests

2 participants