Downgrade requirements from PHP 5.6 to 5.4 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I figured out how to use circleci locally to test this on my machine without pushing each time. |
|
Composer config works now. Just fixing PHP issues... |
sirbrillig
force-pushed
the
support-php-54
branch
from
df866d6 to
d6ac366
Compare
sirbrillig
changed the title
|
Backported to 2.x in https://github.com/sirbrillig/phpcs-variable-analysis/releases/tag/v2.8.3 |
|
Will this change be pushed into the upcoming 3.0 release as well? |
|
Yes. It's already in the main branch and that will become 3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was never a good reason to disallow running under PHP 5.4. This downgrades the requirement and adds CI tests.