Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default schedule #133

Merged
merged 16 commits into from
Feb 2, 2025
Merged

Set default schedule #133

merged 16 commits into from
Feb 2, 2025

Conversation

snowmonkey18
Copy link
Contributor

Add option in ... to set default schedule upon opening hydrant (requested by a user)

snowmonkey18 and others added 14 commits December 30, 2024 23:21
This avoids the nesting indentation that comes from multiple sequential
requests.
This resolves one of the TODO comments, but it is useful since it means
that the URL in the address bar matches what is shown on the page.
IAP or summer of a year where those terms were not scraped separately
should redirect silently to spring or fall of that year, and otherwise
we try to redirect (eventually with some sort of notice to the user) to
the same semester of the current year.
Copy link
Collaborator

@dtemkin1 dtemkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few requested changes :)

src/lib/state.ts Show resolved Hide resolved
src/components/ScheduleSwitcher.tsx Outdated Show resolved Hide resolved
src/components/ScheduleSwitcher.tsx Outdated Show resolved Hide resolved
src/components/ScheduleSwitcher.tsx Show resolved Hide resolved
@dtemkin1 dtemkin1 merged commit 842ea88 into sipb:main Feb 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants