Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of task cleanFrontend #273

Closed
v1nc3n4 opened this issue Nov 26, 2024 · 0 comments
Closed

Removal of task cleanFrontend #273

v1nc3n4 opened this issue Nov 26, 2024 · 0 comments
Assignees
Labels
DONE Issue is fixed and ready to be delivered Feature Request of a new feature or a behaviour change
Milestone

Comments

@v1nc3n4
Copy link
Member

v1nc3n4 commented Nov 26, 2024

The idea behind this removal is to optimize build time when Gradle clean task is executed, and prevent unconditional execution of tasks installNode, resolvePackageManager, installPackageManager, installFrontend.

Projects using the cleanScript property would have to migrate to one of the following workaround:

  1. Create a custom task to clean the project with a Node.js-based command:
tasks.register<Run[Node|Npm|Pnpm|Yarn]TaskType>("cleanFrontend") {
    // Assuming package.json file contains a script named "clean".
    args.set("run clean")
    // Optionally
    dependsOn("installFrontend")
}
  1. Or configure Gradle clean task to remove additional files and/or directories:
tasks.named<Delete>("clean") {
    delete(/* additional files or directories */)
}

Assumption is made that few projects actually used the cleanScript property, and would be impacted by such removal.

@v1nc3n4 v1nc3n4 added this to the 10.0.0 milestone Nov 26, 2024
@v1nc3n4 v1nc3n4 self-assigned this Nov 26, 2024
@v1nc3n4 v1nc3n4 added Feature Request of a new feature or a behaviour change IN PROGRESS Design and implementation are in progress labels Nov 26, 2024
@v1nc3n4 v1nc3n4 added DONE Issue is fixed and ready to be delivered and removed IN PROGRESS Design and implementation are in progress labels Nov 28, 2024
@v1nc3n4 v1nc3n4 closed this as completed Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DONE Issue is fixed and ready to be delivered Feature Request of a new feature or a behaviour change
Projects
None yet
Development

No branches or pull requests

1 participant