Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use random port for test:webworker #2568

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

rluvaton
Copy link
Contributor

Purpose (TL;DR) - mandatory

Dev machine may already have port 8080 taken, which will fail the test, so listening to a random port instead

How to verify - mandatory

  1. Check out this branch
  2. npm install
  3. npm test

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1eb070a) 96.05% compared to head (bb317a2) 96.05%.

❗ Current head bb317a2 differs from pull request most recent head a59bb6e. Consider uploading reports for the commit a59bb6e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2568   +/-   ##
=======================================
  Coverage   96.05%   96.05%           
=======================================
  Files          41       41           
  Lines        1928     1928           
=======================================
  Hits         1852     1852           
  Misses         76       76           
Flag Coverage Δ
unit 96.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatso83 fatso83 merged commit 08d0696 into sinonjs:main Oct 31, 2023
7 checks passed
@rluvaton rluvaton deleted the use-random-port branch October 31, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants