Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use migration guide include in guide index #1838

Merged
merged 1 commit into from
Jun 14, 2018

Conversation

fatso83
Copy link
Contributor

@fatso83 fatso83 commented Jun 14, 2018

Purpose (TL;DR)

Avoids landing in the situation where we remember to update one place, but not the other.

How to verify

  1. bundle install && (cd docs && bundle exec jekyll serve)
  2. Open http://localhost:4000/guides/
  3. Open http://localhost/releases/v6.0.0 and check the "Migration guides" paragraph is the same as in the previous bullet point

Avoid landing in the situation where we remember to update
one place, but not the other.

Ref sinonjs#1829 (comment)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.299% when pulling 4ebf9b6 on fatso83:docs-include-issue into 05d7990 on sinonjs:master.

@fatso83 fatso83 merged commit d2983f1 into sinonjs:master Jun 14, 2018
@fatso83 fatso83 deleted the docs-include-issue branch June 14, 2018 12:58
franck-romano pushed a commit to franck-romano/sinon that referenced this pull request Oct 1, 2019
Avoid landing in the situation where we remember to update one place, but not the other.

Ref sinonjs#1829 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants