Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert esm for 5x #1834

Closed
wants to merge 5 commits into from
Closed

Revert esm for 5x #1834

wants to merge 5 commits into from

Conversation

mroderick
Copy link
Member

Purpose (TL;DR) - mandatory

How to verify - mandatory

  1. Check out this branch
  2. npm install

Checklist for author

  • npm run lint passes
  • References to standard library functions are cached.

@mroderick mroderick mentioned this pull request Jun 8, 2018
Merged
@fatso83
Copy link
Contributor

fatso83 commented Jun 8, 2018

it was quite intentional i didn't make that a PR, because I don't think it should revert the changes on the master branch.

@mroderick
Copy link
Member Author

Apologies, I'll close it and let you do it properly

@mroderick mroderick closed this Jun 8, 2018
@fatso83
Copy link
Contributor

fatso83 commented Jun 8, 2018

5.1.1 is out :)

@fatso83 fatso83 deleted the revert-esm-for-5x branch June 8, 2018 19:43
@mroderick
Copy link
Member Author

5.1.1 is out :)

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroderick @fatso83