Documentation update for assert.calledWithNew #1544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR)
Documentation update for #1535 that adds missing assert.calledWithNew.
Background (Problem in detail)
It was reported that there was no assert.calledWithNew, while Assert did feature most other assertions that Spy had.
Solution
Upon investigation, it turned out that Assert did in fact have this method, but it had been left out in the API documentation.
How to verify
npm install
node
var sinonAssert = require("./lib/sinon/assert")
var sinonSpy = require("./lib/sinon/spy")
var testSpy = sinonSpy()
new testSpy()
sinonAssert.calledWithNew(testSpy)
// this should not throw an exceptionChecklist for author
npm run lint
passes