fix: actaully reset 'injectedKeys' (#2456)

* refactor: Remove single-use variable * fix: actaully reset 'injectedKeys' Re-assigning the local variable `injectedKeys` would not change `sandbox.injectedKeys`, thus `restoreContext` doesn't fully restore the context. See: https://lgtm.com/projects/g/sinonjs/sinon/snapshot/9e09e7d79bac5808ca98fac4f7419a20be4fc43d/files/lib/sinon/sandbox.js?sort=name&dir=ASC&mode=heatmap#x9f770d565ef51b7d:1 * Update lib/sinon/sandbox.js Co-authored-by: Phred Lane <[email protected]> --------- Co-authored-by: Phred Lane <[email protected]>
sinonjs · Aug 9, 2023 · 305fb6c · 305fb6c
1 parent 8186280
commit 305fb6c
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/lib/sinon/sandbox.js b/lib/sinon/sandbox.js
@@ -197,18 +197,15 @@ function Sandbox() {
     };
 
     sandbox.restoreContext = function restoreContext() {
-        let injectedKeys = sandbox.injectedKeys;
-        const injectInto = sandbox.injectInto;
-
-        if (!injectedKeys) {
+        if (!sandbox.injectedKeys) {
             return;
         }
 
-        forEach(injectedKeys, function (injectedKey) {
-            delete injectInto[injectedKey];
+        forEach(sandbox.injectedKeys, function (injectedKey) {
+            delete sandbox.injectInto[injectedKey];
         });
 
-        injectedKeys = [];
+        sandbox.injectedKeys.length = 0;
     };
 
     function getFakeRestorer(object, property) {