Fix compatibility with Sinon 3 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With release 1.0.0 we removed all uses of sinon.getConfig so it no longer makes sense to check for this method. This closes sinonjs#77
The test config now uses the new config object that arrived with Sinon 3. See http://sinonjs.org/releases/v3.0.0/fake-timers/
Start using the factory method API available from Sinon 3.1, while keeping backwards compatibility.
Closed
|
I reference Sinon 3.1 in the source here, but it has not yet been released (tested against the most recent |
|
Sinon 3.1 has now been released, so I just restarted the (already green) build to verify that it still works (it did). |
|
👍 |
|
Released as sinon-test 2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix for #77, but also work that will make it work nicely once the deprecated methods from sinonjs/sinon#1515 are removed with version 4 of Sinon.