Skip to content

Commit

Permalink
chore: remove dependency on bane
Browse files Browse the repository at this point in the history
  • Loading branch information
dominykas authored and mantoni committed Jun 16, 2020
1 parent af98b83 commit 3010499
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 23 deletions.
2 changes: 1 addition & 1 deletion lib/assert-equals-host-objects.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ describe("assert.equals host objects", function() {

afterEach(function() {
sinon.restore();
referee.off();
referee.removeAllListeners();
referee.count = 0;
delete referee.throwOnFailure;
});
Expand Down
2 changes: 1 addition & 1 deletion lib/assert.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ var referee = require("../lib/referee");
describe("assert", function() {
afterEach(function() {
sinon.restore();
referee.off();
referee.removeAllListeners();
delete referee.throwOnFailure;
});

Expand Down
2 changes: 1 addition & 1 deletion lib/custom-assertions.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe("custom assertions", function() {

afterEach(function() {
sinon.restore();
referee.off();
referee.removeAllListeners();
delete referee.throwOnFailure;

delete referee.assert.custom;
Expand Down
2 changes: 1 addition & 1 deletion lib/expect.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ describe("expect", function() {

afterEach(function() {
sinon.restore();
referee.off();
referee.removeAllListeners();
delete referee.throwOnFailure;
});

Expand Down
4 changes: 2 additions & 2 deletions lib/referee.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
"use strict";

var bane = require("bane");
var EventEmitter = require("events");

var referee = bane.createEventEmitter();
var referee = new EventEmitter();

// construct the public API
referee.add = require("./create-add")(referee);
Expand Down
15 changes: 6 additions & 9 deletions lib/referee.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

var referee = require("./referee");
var assert = require("assert");
var EventEmitter = require("events");

describe("API", function() {
describe(".add", function() {
Expand Down Expand Up @@ -77,29 +78,25 @@ describe("API", function() {
// this prevents accidental expansions of the public API
it("should only have expected properties", function() {
var expectedProperties = JSON.stringify([
"_events",
"_eventsCount",
"_maxListeners",
"add",
"assert",
"bind",
"captureException",
"emit",
"equals",
"errback",
"errbacks",
"expect",
"fail",
"listeners",
"match",
"off",
"on",
"once",
"pass",
"refute",
"setFormatter",
"supervisors",
"verifier"
]);
var actualProperties = JSON.stringify(Object.keys(referee).sort());

assert.equal(actualProperties, expectedProperties);

assert.ok(referee instanceof EventEmitter);
});
});
2 changes: 1 addition & 1 deletion lib/refute.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var referee = require("../lib/referee");

describe("refute", function() {
afterEach(function() {
referee.off();
referee.removeAllListeners();
delete referee.throwOnFailure;
});

Expand Down
2 changes: 1 addition & 1 deletion lib/test-helper/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ var testHelper = {
sinon.restore();
delete testHelper.okListener;
delete testHelper.failListener;
referee.off();
referee.removeAllListeners();
delete referee.throwOnFailure;
},

Expand Down
5 changes: 0 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
"@sinonjs/formatio": "^5.0.1",
"@sinonjs/samsam": "^5.0.2",
"array-from": "2.1.1",
"bane": "^1.x",
"lodash.includes": "^4.3.0",
"lodash.isarguments": "^3.1.0",
"object-assign": "^4.1.1"
Expand Down

0 comments on commit 3010499

Please sign in to comment.