Convert timer delay to number if not already #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey this looks cool - would you mind adding a test? |
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
==========================================
+ Coverage 92.75% 93.11% +0.36%
==========================================
Files 1 1
Lines 552 552
==========================================
+ Hits 512 514 +2
+ Misses 40 38 -2
Continue to review full report at Codecov.
|
|
(Tests are basically one big file https://github.com/sinonjs/fake-timers/blob/master/test/fake-timers-test.js ) |
|
@benjamingr test added |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix issue #315 by checking if
timer.delayis a number. If it isn't make it one by parsing it to an integer.